Skip to content

UI Tests for the extension using selenium and behave#5912

Merged
DonJayamanne merged 23 commits intomicrosoft:masterfrom
DonJayamanne:pysTwo
Jul 1, 2019
Merged

UI Tests for the extension using selenium and behave#5912
DonJayamanne merged 23 commits intomicrosoft:masterfrom
DonJayamanne:pysTwo

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Jun 5, 2019 •
edited
Loading

For #4692

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
    • Will do this separately.

@DonJayamanne DonJayamanne force-pushed the pysTwo branch 11 times, most recently from 0e810c9 to 7bfbcf1 Compare June 12, 2019 20:47
@DonJayamanne DonJayamanne force-pushed the pysTwo branch 2 times, most recently from c0208ef to d663cac Compare June 13, 2019 08:06
@DonJayamanne DonJayamanne changed the title WIP UI Tests Jun 13, 2019
@DonJayamanne DonJayamanne force-pushed the pysTwo branch 6 times, most recently from 903ef0c to ba77232 Compare June 21, 2019 20:42
rchiodo
rchiodo reviewed Jun 24, 2019
View reviewed changes
Comment thread uitests/uitests/features/datascience/basic.feature
rchiodo
rchiodo approved these changes Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne force-pushed the pysTwo branch 2 times, most recently from be2aa51 to 011dc39 Compare June 25, 2019 22:02
@DonJayamanne DonJayamanne mentioned this pull request Jun 25, 2019
Closed
kimadeline
kimadeline suggested changes Jun 27, 2019
View reviewed changes
Copy link
Copy Markdown

@kimadeline kimadeline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major changes, mostly clarification and typos ✏️

Comment thread .vscode/settings.json
Comment thread build/ci/templates/uitest_jobs.yml Outdated
Comment thread uitests/README.md Outdated
Comment thread uitests/README.md Outdated
Comment thread uitests/uitests/bootstrap/extension/extension.js
kimadeline
kimadeline reviewed Jun 28, 2019
View reviewed changes
Comment thread uitests/README.md
@DonJayamanne DonJayamanne changed the title UI Tests UI Tests for the extension using selenium and behave Jul 1, 2019
@DonJayamanne DonJayamanne merged commit 20ef954 into microsoft:master Jul 1, 2019
This was referenced Jul 2, 2019
Merged
Merged
Closed
Merged
Merged
Merged
Closed
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
@DonJayamanne DonJayamanne deleted the pysTwo branch September 29, 2019 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

+1 more reviewer

@kimadeline kimadeline kimadeline requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @rchiodo @kimadeline